lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 10 Nov 2014 13:11:05 +0100 From: Peter Zijlstra <peterz@...radead.org> To: Namhyung Kim <namhyung@...nel.org> Cc: Arnaldo Carvalho de Melo <acme@...nel.org>, Ingo Molnar <mingo@...nel.org>, Paul Mackerras <paulus@...ba.org>, Namhyung Kim <namhyung.kim@....com>, LKML <linux-kernel@...r.kernel.org>, Jiri Olsa <jolsa@...hat.com>, Adrian Hunter <adrian.hunter@...el.com>, David Ahern <dsahern@...il.com> Subject: Re: [PATCH 1/3] perf tools: Allow vmlinux to fallback to kallsyms on NO_LIBELF=1 On Mon, Nov 10, 2014 at 03:33:11PM +0900, Namhyung Kim wrote: > Hmm.. I don't think it's specific to the minimal elf parser. The return > value of dso__load_sym() is a number of symbols found so when it sees a > dso with 0 symbols it'll fall back to the next option IMHO (not > tested). Did you see a problem with the current code? So your patch: +++ b/tools/perf/util/symbol-minimal.c @@ -335,6 +335,9 @@ int dso__load_sym(struct dso *dso, struct map *map __maybe_unused, unsigned char *build_id[BUILD_ID_SIZE]; int ret; + if (dso->kernel) + return 0; /* always use kallsyms */ + changes the symbol-minimal.c file to add this exception. That is very much specific to the minimal elf parser, or am I just seeing things? What I was saying, why not have a util/symbol.c change that disregards all DSOs with 0 symbols in. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists