lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun,  9 Nov 2014 17:42:32 -0800
From:	Guenter Roeck <>
Cc:, Guenter Roeck <>,
	Samuel Ortiz <>,
	Lee Jones <>
Subject: [PATCH v6 15/48] mfd: dm355evm_msp: Register with kernel power-off handler

Register with kernel power-off handler instead of setting pm_power_off
directly. Register with low priority to reflect that the original code
only sets pm_power_off if it was not already set.

Cc: Samuel Ortiz <>
Cc: Lee Jones <>
Acked-by: Lee Jones <>
Signed-off-by: Guenter Roeck <>
- This patch: No change.
  Global: Replaced priority defines with enum.
- Rebase to v3.18-rc3
- Do not use notifiers but internal functions and data structures to manage
  the list of power-off handlers. Drop unused parameters from callbacks, and
  make the power-off function type void
- Replace poweroff in all newly introduced variables and in text
  with power_off or power-off as appropriate
- Use define to specify poweroff handler priority
- Use dev_warn instead of dev_err

 drivers/mfd/dm355evm_msp.c | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/drivers/mfd/dm355evm_msp.c b/drivers/mfd/dm355evm_msp.c
index 4c826f7..d9ec1e6 100644
--- a/drivers/mfd/dm355evm_msp.c
+++ b/drivers/mfd/dm355evm_msp.c
@@ -14,6 +14,7 @@
 #include <linux/platform_device.h>
 #include <linux/clk.h>
 #include <linux/module.h>
+#include <linux/pm.h>
 #include <linux/err.h>
 #include <linux/gpio.h>
 #include <linux/leds.h>
@@ -352,14 +353,19 @@ static void dm355evm_command(unsigned command)
 				command, status);
-static void dm355evm_power_off(void)
+static void dm355evm_power_off(struct power_off_handler_block *this)
+static struct power_off_handler_block dm355evm_msp_power_off_hb = {
+	.handler = dm355evm_power_off,
 static int dm355evm_msp_remove(struct i2c_client *client)
-	pm_power_off = NULL;
+	unregister_power_off_handler(&dm355evm_msp_power_off_hb);
 	msp430 = NULL;
 	return 0;
@@ -398,7 +404,9 @@ dm355evm_msp_probe(struct i2c_client *client, const struct i2c_device_id *id)
 		goto fail;
 	/* PM hookup */
-	pm_power_off = dm355evm_power_off;
+	status = register_power_off_handler(&dm355evm_msp_power_off_hb);
+	if (status)
+		dev_warn(&client->dev, "Failed to register power-off handler\n");
 	return 0;

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists