linux-kernel - Re: [PATCH v6 10/10] tpm: TPM 2.0 sysfs attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141110180305.GC5296@obsidianresearch.com>
Date:	Mon, 10 Nov 2014 11:03:05 -0700
From:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
To:	Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
Cc:	Peter Huewe <peterhuewe@....de>, Ashley Lai <ashley@...leylai.com>,
	Marcel Selhorst <tpmdd@...horst.net>,
	tpmdd-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	josh.triplett@...el.com, christophe.ricard@...il.com,
	jason.gunthorpe@...idianresearch.com
Subject: Re: [PATCH v6 10/10] tpm: TPM 2.0 sysfs attributes

On Mon, Nov 10, 2014 at 02:49:54PM +0200, Jarkko Sakkinen wrote:

>  	if (len > le32_to_cpu(cca->cmd_size)) {
> -		dev_err(chip->dev,
> +		dev_err(&chip->dev,

Is this out of sequence in the patch series?

>  
>  	rc = tpm2_do_selftest(chip);
> -	if (rc) {
> -		dev_err(dev, "self-test failed\n");
> +	if (rc)
>  		return rc;
> -	}
>  
>  	rc = tpm_chip_register(chip);
> -	if (rc) {
> -		dev_err(dev, "registering the chip failed\n");
> +	if (rc)
>  		return rc;
> -	}

Ditto.

Also, just:

   return tpm_chip_register(chip);

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/