linux-kernel - Re: [PATCH v2 1/2] ASoC: Remove 'const' from the device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141110201254.65674552@armhf>
Date:	Mon, 10 Nov 2014 20:12:54 +0100
From:	Jean-Francois Moine <moinejf@...e.fr>
To:	Mark Brown <broonie@...nel.org>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Russell King <linux@....linux.org.uk>,
	Lars-Peter Clausen <lars@...afoo.de>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] ASoC: Remove 'const' from the device_node
 pointers

On Mon, 10 Nov 2014 19:03:32 +0000
Mark Brown <broonie@...nel.org> wrote:

> On Sun, Nov 09, 2014 at 08:33:45PM +0100, Jean-Francois Moine wrote:
> > From Russell King:
> > of_node_put() modifies the struct device_node contents.  Therefore,
> > of_node_put() definitely not treating the data pointed to as read-only,
> > and therefore it is completely inappropriate for it to be marked "const".
> 
> Did Russell write this patch (in which case it's missing a signoff and
> his e-mail address above) or are you trying to say "Russell King
> said..."?

Sorry, that was "Russell said ...".
Do you want I resubmit the patch?

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/