linux-kernel - Re: [PATCH] staging: rtl8723au: change typecast to match type returned by htons()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <wrfjlhnivmb9.fsf@redhat.com>
Date:	Mon, 10 Nov 2014 15:21:30 -0500
From:	Jes Sorensen <Jes.Sorensen@...hat.com>
To:	Chris Ruffin <cmruffin@...il.com>
Cc:	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
	devel@...verdev.osuosl.org,
	Larry Finger <Larry.Finger@...inger.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] staging: rtl8723au: change typecast to match type returned by htons()

Chris Ruffin <cmruffin@...il.com> writes:
> Using a u16 pointer typecast for a result from htons() results in the following warning from sparse:
>
> drivers/staging/rtl8723au/core/rtw_xmit.c:1279:36: warning: incorrect type in assignment (different base types)
> drivers/staging/rtl8723au/core/rtw_xmit.c:1279:36:    expected unsigned short [unsigned] [short] [usertype] <noident>
> drivers/staging/rtl8723au/core/rtw_xmit.c:1279:36:    got restricted __be16 [usertype] <noident>
>
> This patch fixes the issue by using an endian-specific typecast
> that will always match the type returned by htons().
>
> Signed-off-by: Chris Ruffin <cmruffin@...il.com>
> ---
>  drivers/staging/rtl8723au/core/rtw_xmit.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Looks fine to me

Signed-off-by: Jes Sorensen <Jes.Sorensen@...hat.com>

>
> diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c b/drivers/staging/rtl8723au/core/rtw_xmit.c
> index a0f7e27..44ef55c 100644
> --- a/drivers/staging/rtl8723au/core/rtw_xmit.c
> +++ b/drivers/staging/rtl8723au/core/rtw_xmit.c
> @@ -1276,7 +1276,7 @@ s32 rtw_put_snap23a(u8 *data, u16 h_proto)
>  	snap->oui[0] = oui[0];
>  	snap->oui[1] = oui[1];
>  	snap->oui[2] = oui[2];
> -	*(u16 *)(data + SNAP_SIZE) = htons(h_proto);
> +	*(__be16 *)(data + SNAP_SIZE) = htons(h_proto);
>  	return SNAP_SIZE + sizeof(u16);
>  }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/