[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20141110113221.17cb1535@notabene.brown>
Date: Mon, 10 Nov 2014 11:32:21 +1100
From: NeilBrown <neilb@...e.de>
To: Евгений Поляков
<zbr@...emap.net>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
GTA04 owners <gta04-owner@...delico.com>
Subject: Re: [PATCH] w1: support auto-load of w1_bq27000 module.
On Mon, 10 Nov 2014 03:11:29 +0300 Евгений Поляков <zbr@...emap.net> wrote:
> Hi
>
> 08.11.2014, 02:33, "NeilBrown" <neilb@...e.de>:
> > 1/ change request_module call to zero-pad single digit
> > family numbers. This appears to be the intention of
> > the code, but not what it actually does.
> >
> > This means that the alias created for W1_FAMILY_SMEM_01
> > might actually be useful.
> >
> > 2/ Define a family name for the BQ27000 battery charge monitor.
> > Unfortunately this is the same number as W1_FAMILY_SMEM_01
> > so if both a compiled on a system, one module might need to
> > be blacklisted.
> >
> > 3/ Add a MODULE_ALIAS for the bq27000.
> >
> > Signed-off-by: NeilBrown <neilb@...e.de>
>
> Looks good to me.
> Acked-by: Evgeniy Polyakov <zbr@...emap.net>
>
> Which tree should this patch use to get into the kernel?
MAINTAINERS lists you as the maintainer, so I though you would know.
When is doubt: send to akpm .. or gregkh.
It looks like greg has more Signed-off-by's in drivers/w1 than akpm,
so I'll add your acked-by and send to him.
Thanks,
NeilBrown
Content of type "application/pgp-signature" skipped
Powered by blists - more mailing lists