linux-kernel - Re: [PATCH] ARM: dts: tegra: move serial aliases to per-board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Nov 2014 14:45:09 -0800
From:	Olof Johansson <olof@...om.net>
To:	Stephen Warren <swarren@...dotorg.org>
Cc:	Thierry Reding <thierry.reding@...il.com>,
	Alexandre Courbot <gnurou@...il.com>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	gregkh@...ux-foundation.org, Laxman Dewangan <ldewangan@...dia.com>
Subject: Re: [PATCH] ARM: dts: tegra: move serial aliases to per-board

[again in plain text mode. Sigh]


On Tue, Nov 11, 2014 at 1:14 PM, Stephen Warren <swarren@...dotorg.org> wrote:
> On 11/11/2014 01:49 PM, Olof Johansson wrote:
>>
>> There are general changes pending to make the /aliases/serial* entries
>> number the serial ports on the system. On tegra, so far the ports have
>> been
>> just numbered dynamically as they are configured so that makes them
>> change.
>>
>> To avoid this, add specific aliases per board to keep the old numbers.
>> This
>> allows us to change the numbering by default on future SoCs while keeping
>> the
>> numbering on existing boards.
>
>
> This change seems mostly OK to me. FWIW though, I had suggested this
> approach when the UART aliases were first added, and Laxman disagreed with
> it. See commit b6551bb933f9 "ARM: tegra: dts: add aliases and DMA requestor
> for serial controller", and its discussion:
> https://lkml.org/lkml/2012/12/25/4. I've CC'd Laxman in case he still
> objects.
>
>> Signed-off-by: Olof Johansson <olof@...om.net>
>> ---
>>
>> Stephen/Thierry/Alex, as noticed this week we really should try to get
>> this in before the 3.19 merge window so that the global aliases change
>> can happen there without regression.
>
>
> How did we resolve the issue that patch causes with old DTs; namely that it
> causes a change in behaviour for those old DTs? On IRC, I'd wondered whether
> we should set a flag so the kernel ignored aliases for boards containing
> currently upstreamed Tegra SoCs so that issue wouldn't occur. If we did
> that, we wouldn't need this patch.

Another way could be to remove aliases from the kernel side during
booting if they're found. Anyway, feel free to send a patch to do that
if that's your preference.


Thanks,

-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/