| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 11 Nov 2014 11:55:51 +0100 From: Jürgen Groß <jgross@...e.com> To: David Vrabel <david.vrabel@...rix.com>, linux-kernel@...r.kernel.org, xen-devel@...ts.xensource.com, konrad.wilk@...cle.com, boris.ostrovsky@...cle.com, x86@...nel.org, tglx@...utronix.de, mingo@...hat.com, hpa@...or.com Subject: Re: [Xen-devel] [PATCH V3 1/8] xen: Make functions static On 11/11/2014 11:50 AM, David Vrabel wrote: > On 11/11/14 10:36, Juergen Gross wrote: >> On 11/11/2014 11:21 AM, David Vrabel wrote: >>> On 11/11/14 05:43, Juergen Gross wrote: >>>> Some functions in arch/x86/xen/p2m.c are used locally only. Make them >>>> static. Rearrange the functions in p2m.c to avoid forward declarations. >>>> >>>> While at it correct some style issues (long lines, use pr_warn()). >>> >>> Please don't add extra stuff like this. In general if you feel yourself >>> wring "while at it..." or "also..." then you need another patch. >> >> I applied the changes only to functions I was moving, as checkpatch was >> complaining. Documentation says this should be avoided only when moving >> functions between files. > > If the documentation says that then it is wrong. Fix the style issues > in one patch and then move the functions in another. Okay. Juergen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists