linux-kernel - Re: [PATCH] virtio_console: move early VQ enablement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Nov 2014 12:24:24 +1000
From:	Dave Airlie <airlied@...il.com>
To:	Josh Boyer <jwboyer@...oraproject.org>
Cc:	"Michael S. Tsirkin" <mst@...hat.com>,
	Cornelia Huck <cornelia.huck@...ibm.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Thomas Graf <tgraf@...g.ch>,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
	virtualization@...ts.linux-foundation.org,
	KVM list <kvm@...r.kernel.org>
Subject: Re: [PATCH] virtio_console: move early VQ enablement

On 21 October 2014 03:09, Josh Boyer <jwboyer@...oraproject.org> wrote:
> On Mon, Oct 20, 2014 at 10:05 AM, Michael S. Tsirkin <mst@...hat.com> wrote:
>> On Mon, Oct 20, 2014 at 03:58:49PM +0200, Cornelia Huck wrote:
>>> Commit f5866db6 (virtio_console: enable VQs early) tried to make
>>> sure that DRIVER_OK was set when virtio_console started using its
>>> virtqueues. Doing this in add_port(), however, means that we try
>>> to set DRIVER_OK again when when a port is dynamically added after
>>> the probe function is done.
>>>
>>> Let's move virtio_device_ready() to the probe function just before
>>> trying to use the virtqueues instead. This is fine as nothing can
>>> fail inbetween.
>>>
>>> Reported-by: Thomas Graf <tgraf@...g.ch>
>>> Reviewed-by: Michael S. Tsirkin <mst@...hat.com>
>>> Signed-off-by: Cornelia Huck <cornelia.huck@...ibm.com>
>>
>> Thanks!
>>
>> Acked-by: Michael S. Tsirkin <mst@...hat.com>
>> Tested-by: Michael S. Tsirkin <mst@...hat.com>
>
> This fixed my KVM guest boot issue with 3.18-rc1.  Thanks for such a quick fix.
>
> Tested-by: Josh Boyer <jwboyer@...oraproject.org>

ping So who's merging this? Rusty?

still happens in -rc4.

Dave.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/