lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 11 Nov 2014 10:05:11 -0300 From: Arnaldo Carvalho de Melo <acme@...nel.org> To: Adrian Hunter <adrian.hunter@...el.com> Cc: Peter Zijlstra <peterz@...radead.org>, linux-kernel@...r.kernel.org, David Ahern <dsahern@...il.com>, Frederic Weisbecker <fweisbec@...il.com>, Jiri Olsa <jolsa@...hat.com>, Namhyung Kim <namhyung@...il.com>, Paul Mackerras <paulus@...ba.org>, Stephane Eranian <eranian@...gle.com> Subject: Re: [PATCH] perf tools: Fix annotation with kcore Em Tue, Nov 11, 2014 at 12:04:54PM +0200, Adrian Hunter escreveu: > Patch "perf tools: Fix build-id matching on vmlinux" So, I will check this, but please state for which branch this is supposed to be applied, i.e. does it fixes perf/urgent stuff and thus needs to go ASAP, or is this something that affects perf/core and thus can wait till I process more urgent stuff? - Arnaldo > breaks annotation with kcore. The problem is that > symbol__annotate() first gets the filename based on > the build-id which was previously not set. > This patch provides a quick fix, however there should > probably be only one way to determine the filename. e.g. > symbol__annotate() should use the same way as > dso__data_fd(). > > Signed-off-by: Adrian Hunter <adrian.hunter@...el.com> > --- > tools/perf/util/annotate.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c > index 7dabde1..873c877 100644 > --- a/tools/perf/util/annotate.c > +++ b/tools/perf/util/annotate.c > @@ -915,6 +915,8 @@ int symbol__annotate(struct symbol *sym, struct map *map, size_t privsize) > return -ENOMEM; > } > goto fallback; > + } else if (dso__is_kcore(dso)) { > + goto fallback; > } else if (readlink(symfs_filename, command, sizeof(command)) < 0 || > strstr(command, "[kernel.kallsyms]") || > access(symfs_filename, R_OK)) { > -- > 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists