[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 11 Nov 2014 08:53:13 -0800
From: Kevin Hilman <khilman@...nel.org>
To: Caesar Wang <caesar.wang@...k-chips.com>
Cc: linus.walleij@...aro.org, linux-arm-kernel@...ts.infradead.org,
Heiko Stuebner <heiko@...ech.de>,
Russell King <linux@....linux.org.uk>,
Rob Herring <robh+dt@...nel.org>,
Pawel Moll <pawel.moll@....com>,
Mark Rutland <mark.rutland@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>,
Grant Likely <grant.likely@...aro.org>,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
Randy Dunlap <rdunlap@...radead.org>,
linux-doc@...r.kernel.org, dianders@...omium.org,
linux-rockchip@...ts.infradead.org,
Ulf Hansson <ulf.hansson@...aro.org>,
Dmitry Torokhov <dmitry.torokhov@...il.com>,
fzf@...k-chips.com, cf@...k-chips.com,
Jack Dai <jack.dai@...k-chips.com>,
"jinkun.hong" <jinkun.hong@...k-chips.com>
Subject: Re: [PATCH v10 2/3] power-domain: rockchip: add power doamin driver
Caesar Wang <caesar.wang@...k-chips.com> writes:
> In order to meet high performance and low power requirements, a power
> management unit is designed or saving power when RK3288 in low power mode.
> The RK3288 PMU is dedicated for managing the power ot the whole chip.
>
> Signed-off-by: Jack Dai <jack.dai@...k-chips.com>
> Signed-off-by: jinkun.hong <jinkun.hong@...k-chips.com>
> Signed-off-by: Caesar Wang <caesar.wang@...k-chips.com>
>
> ---
>
> Changes in v10:
> - this switches over domain infos to use masks instead of recomputing
> them each time and also gets rid of custom domain translator and
> uses standard onecell on.
>
> Changes in v9:
> - fix v8 changes as follows:
> - This reconciles the v2 and v7 code so that we power domain have
> lists of clocks they toggle on and off during power transitions and
> independently from power domains clocks we attach clocks to devices
> comprising power domain and prepare them so they are turn on and off
> by runtime PM.
I still don't like having lists of clocks in the power-domain DT.
DT is supposed to describe the hardware, and clocks are properties of
devices, not power-domains, so the DT description should follow from that.
I understand that some device may not be probed etc. when a power-domain
needs to transition, but the power-domain driver can still get the list
of clocks it needs from the device nodes within the domain, so it
shouldn't matter whether devices are probed or not.
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists