linux-kernel - Re: [PATCH v6 00/48] kernel: Add support for power-off handler call chain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Nov 2014 19:50:20 +0100
From:	Pavel Machek <pavel@....cz>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
	Alan Cox <gnomes@...rguk.ukuu.org.uk>,
	Alexander Graf <agraf@...e.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Heiko Stuebner <heiko@...ech.de>, LeeJon@...ck-us.net
Subject: Re: [PATCH v6 00/48] kernel: Add support for power-off handler call
 chain

On Tue 2014-11-11 10:20:23, Guenter Roeck wrote:
> On Mon, Nov 10, 2014 at 09:33:48AM +0100, Pavel Machek wrote:
> > Hi!
> > 
> > > Introduce a system power-off handler call chain to solve the described
> > > problems.  This call chain is expected to be executed from the architecture
> > > specific machine_power_off() function.  Drivers providing system power-off
> > > functionality are expected to register with this call chain.  By using the
> > > priority field in the notifier block, callers can control power-off
> > > handler
> > 
> > Linus rather disliked the idea of notifier chains for this... And I
> > don't see how it got addressed.
> > 
> Hi all,
> 
> After more thought, I concluded that it is technically impossible to support
> multiple power-off handlers without some kind of list or call chain, no matter
> how it is called. Given the opposition from Linus and the power maintainers
> to the series, I decided to shelf it.

Well, you can still do preparations -- current code directly setting
pm_power_off is ugly -- so that if you want to switch to call chain
later, it will be easy.

And if that does not happen, we still get the cleanup :-).

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/