linux-kernel - Re: [PATCH 02/13] ARM: STi: DT: STiH416: Add DT node for the stih415/6 usb2 phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141112135500.GC20187@griffinp-ThinkPad-X1-Carbon-2nd>
Date:	Wed, 12 Nov 2014 13:55:00 +0000
From:	Peter Griffin <peter.griffin@...aro.org>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	srinivas.kandagatla@...il.com, maxime.coquelin@...com,
	patrice.chotard@...com, devicetree@...r.kernel.org
Subject: Re: [PATCH 02/13] ARM: STi: DT: STiH416: Add DT node for the
 stih415/6 usb2 phy

Hi Lee,

Thanks for reviewing.

On Mon, 10 Nov 2014, Lee Jones wrote:

> On Fri, 07 Nov 2014, Peter Griffin wrote:
> 
> > This usb picophy is found on stih415/6 SoC.
> 
> Then shouldn't it live in stih41x.dtsi?

No, it is the same ip block, and underlying driver, but needs a different
compatible string as it's wired up to different sysconfig registers on the SoC.

> 
> > Signed-off-by: Peter Griffin <peter.griffin@...aro.org>
> > ---
> >  arch/arm/boot/dts/stih416.dtsi | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/stih416.dtsi b/arch/arm/boot/dts/stih416.dtsi
> > index 1137bdf..0f3019a 100644
> > --- a/arch/arm/boot/dts/stih416.dtsi
> > +++ b/arch/arm/boot/dts/stih416.dtsi
> > @@ -316,5 +316,14 @@
> >  
> >  			status	        = "disabled";
> >  		};
> > +
> > +		usb2_phy: usb2phy@0 {
> > +			compatible = "st,stih416-usb-phy";
> > +			#phy-cells = <0>;
> > +			st,syscfg = <&syscfg_rear>;
> > +			clocks = <&clk_sysin>;
> > +			clock-names = "osc_phy";
> > +
> 
> Remove this '\n'.

Fixed in v2.

regards,

Peter.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/