| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1415809894-24084-1-git-send-email-martink@posteo.de> Date: Wed, 12 Nov 2014 17:31:34 +0100 From: Martin Kepplinger <martink@...teo.de> To: miklos@...redi.hu Cc: fuse-devel@...ts.sourceforge.net, thierry.reding@...il.com, gregkh@...uxfoundation.org, giedriuswork@...il.com, linux-kernel@...r.kernel.org, Martin Kepplinger <martink@...teo.de> Subject: [PATCH] fuse: don't check for file->private_data on open(). The miscdevice core now sets file->private_data to the struct miscdevice so don't fail when this is not NULL. Reported-by: Thierry Reding <thierry.reding@...il.com> Signed-off-by: Martin Kepplinger <martink@...teo.de> --- This is a question: what does this check provide and does overwriting file->private_data make any difference? Is open() by the user not allowed here, if file->private_data is set? thanks!! fs/fuse/inode.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c index 03246cd..562407e 100644 --- a/fs/fuse/inode.c +++ b/fs/fuse/inode.c @@ -1092,9 +1092,6 @@ static int fuse_fill_super(struct super_block *sb, void *data, int silent) } mutex_lock(&fuse_mutex); - err = -EINVAL; - if (file->private_data) - goto err_unlock; err = fuse_ctl_add_conn(fc); if (err) -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists