linux-kernel - Re: [patch 16/16] PCI/MSI: Enhance core to support hierarchy irqdomain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1411121743170.3935@nanos>
Date:	Wed, 12 Nov 2014 17:43:57 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Marc Zyngier <marc.zyngier@....com>
cc:	LKML <linux-kernel@...r.kernel.org>,
	Jiang Liu <jiang.liu@...ux.intel.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	Yingjoe Chen <yingjoe.chen@...iatek.com>,
	Yijing Wang <wangyijing@...wei.com>
Subject: Re: [patch 16/16] PCI/MSI: Enhance core to support hierarchy
 irqdomain

On Wed, 12 Nov 2014, Marc Zyngier wrote:
> > +#ifdef CONFIG_PCI_MSI_IRQ_DOMAIN
> > +void pci_msi_domain_write_msg(struct irq_data *irq_data, struct msi_msg *msg)
> > +{
> > +	struct msi_desc *desc = irq_data->msi_desc;
> > +
> > +	/*
> > +	 * MSI-X message is written per-IRQ.
> > +	 * MSI message denotes a contiguous group of IRQs, written for 0th IRQ.
> > +	 */
> > +	if (desc->irq == irq_data->irq)
> > +		pci_write_msi_msg(desc, msg);
> 
> My compiler barks at this. Shouldn't that be either:
> 		pci_write_msi_msg(desc->irq, msg);
> or
> 		__pci_write_msi_msg(desc, msg);

The latter.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/