linux-kernel - Re: [PATCH] pci: support Thunderbolt requirements for I/O resources.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMxnaaXOa_GAFwK+tUrO8DBjENqdd9uaQHKqEMm+i4754Ch3gQ@mail.gmail.com>
Date:	Wed, 12 Nov 2014 21:19:05 +0100
From:	Andreas Noever <andreas.noever@...il.com>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
Cc:	Bjorn Helgaas <bhelgaas@...gle.com>,
	Michael Jamet <michael.jamet@...el.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	amir.jer.levy@...el.com, dan.alloun@...el.com,
	Rafael Wysocki <rjw@...ysocki.net>
Subject: Re: [PATCH] pci: support Thunderbolt requirements for I/O resources.

On Wed, Nov 12, 2014 at 7:30 PM, Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> On Wed, Nov 12, 2014 at 7:29 PM, Bjorn Helgaas <bhelgaas@...gle.com> wrote:
>
> []
>
>>> To prevent this, we detect a chain contains a Thunderbolt
>>> device by checking the Thunderbolt PCI device id.
>>
>> I'm really not happy about checking a list of device IDs to identify
>> Thunderbolt devices.  Surely there's a better way, because a list like
>> this has to be updated regularly.
>
> I recently proposed internally to use quirks (pci_fixup_early) for
> that, but apparently Michael didn't have time to answer. It might be
> he can just comment here since the patch already public.

In any case: this will interfere with thunderbolt hotplug on Apple
systems, where we do not have BIOS support and have to handle hotplug
events and assign resources ourselves. So please add a DMI check for
Apple (the reverse of what we do in
http://lxr.free-electrons.com/source/drivers/thunderbolt/nhi.c?v=3.17#L664
).

Thanks,
Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/