lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 12 Nov 2014 22:50:37 +0100 From: SF Markus Elfring <elfring@...rs.sourceforge.net> To: Dan Carpenter <dan.carpenter@...cle.com> CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, devel@...verdev.osuosl.org, trivial@...nel.org, kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org, Coccinelle <cocci@...teme.lip6.fr> Subject: Re: [PATCH v2 2/2] staging: rtl8188eu: Better memory clean-up in efuse_phymap_to_logical() >> + goto cleanup1; > > 1) Don't use GW-BASIC label names. Label names should reflect what the > label does such as free_fuse_word or free_fuse_tabel. > > 2) Don't use do-nothing labels. Just return directly. Does the document "CodingStyle" need any extensions for special cases? Are there any update candidates in the chapter "7: Centralized exiting of functions"? Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists