linux-kernel - [PATCH] ftrace: fix traceoff_on_warning handling on boot command line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141112231400.GL12281@uudg.org>
Date:	Wed, 12 Nov 2014 21:14:00 -0200
From:	"Luis Claudio R. Goncalves" <lclaudio@...g.org>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	linux-kernel@...r.kernel.org,
	Clark Williams <clark.williams@...il.com>
Subject: [PATCH] ftrace: fix traceoff_on_warning handling on boot command line

Steven,

While backporting traceoff_on_warning to 3.10.33-rt we noticed a slightly
difference between what was stated on Documentation/kernel-parameters.txt
and the actual code.

Please consider the following patch for inclusion.

Best regards,
Luis

------

ftrace: fix traceoff_on_warning handling on boot command line

According to the documentation, adding "traceoff_on_warning" to the boot
command line should be enough to enable the feature. But right now it is
necessary to specify "traceoff_on_warning=". Along with fixing that, also
verify if the value passed, if any, is either "0" or "off".

Signed-off-by: Luis Claudio R. Goncalves <lgoncalv@...hat.com>

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index f68981f..a956a60 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -155,10 +155,11 @@ __setup("ftrace_dump_on_oops", set_ftrace_dump_on_oops);

 static int __init stop_trace_on_warning(char *str)
 {
-	__disable_trace_on_warning = 1;
+	if ((strcmp(str, "=0") != 0 && strcmp(str, "=off") != 0))
+		__disable_trace_on_warning = 1;
 	return 1;
 }
-__setup("traceoff_on_warning=", stop_trace_on_warning);
+__setup("traceoff_on_warning", stop_trace_on_warning);

 static int __init boot_alloc_snapshot(char *str)
 {

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/