linux-kernel - Re: [PATCH 2/3 v3] drivers/bus: Freescale Management Complex (fsl-mc) bus driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5462BF8D.2090805@freescale.com>
Date:	Tue, 11 Nov 2014 20:01:49 -0600
From:	German Rivera <German.Rivera@...escale.com>
To:	Alexander Graf <agraf@...e.de>, <gregkh@...uxfoundation.org>,
	<arnd@...db.de>, <linux-kernel@...r.kernel.org>
CC:	<stuart.yoder@...escale.com>, <Kim.Phillips@...escale.com>,
	<scottwood@...escale.com>, <bhamciu1@...escale.com>,
	<R89243@...escale.com>, <Geoff.Thorpe@...escale.com>,
	<bhupesh.sharma@...escale.com>, <nir.erez@...escale.com>,
	<richard.schmitt@...escale.com>
Subject: Re: [PATCH 2/3 v3] drivers/bus: Freescale Management Complex (fsl-mc)
 bus driver

On 11/06/2014 07:50 AM, Alexander Graf wrote:
>
[cut]
>> +++ b/drivers/bus/fsl-mc/Kconfig
>> @@ -0,0 +1,13 @@
>> +#
>> +# Freescale Management Complex (MC) bus drivers
>> +#
>> +# Copyright (C) 2014 Freescale Semiconductor, Inc.
>> +#
>> +# This file is released under the GPLv2
>> +#
>> +
>> +config FSL_MC_BUS
>> +	tristate "Freescale Management Complex (MC) bus driver"
>> +	help
>> +	  Driver to enable the bus infrastructure for the Freescale
>> +          QorIQ Management Complex.
>
> Isn't this missing some scope limitations? Should we really have the
> driver enabled on x86 for example?
>
I will add depends on OF && ARM64

> I would also make this slightly more verbose. People don't necessarily
> know what the QorIQ Management Complex is. Give people some idea what
> they're dealing with and preferably tell them hints that guide them from
> "SoC name" to "should I enable this option?".
>
> Also, usually the help text gives some guidance on what to do with the
> option if you're not sure. In this case, I would say advise the user to
> say N.
>
Will do.

>
> Alex
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/