linux-kernel - Re: [PATCH 1/2] mm: page_isolation: check pfn validity before access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL1ERfO5GNanwLkL36b11NDUTptzGrxVF=rN913bHjS9wFNWKQ@mail.gmail.com>
Date:	Wed, 12 Nov 2014 10:10:36 +0800
From:	Weijie Yang <weijie.yang.kh@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Weijie Yang <weijie.yang@...sung.com>,
	kamezawa.hiroyu@...fujitsu.com, Minchan Kim <minchan@...nel.org>,
	mgorman@...e.de, mina86@...a86.com,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Linux-MM <linux-mm@...ck.org>, isimatu.yasuaki@...fujitsu.com
Subject: Re: [PATCH 1/2] mm: page_isolation: check pfn validity before access

On Wed, Nov 12, 2014 at 6:23 AM, Andrew Morton
<akpm@...ux-foundation.org> wrote:
> On Thu, 06 Nov 2014 16:08:02 +0800 Weijie Yang <weijie.yang@...sung.com> wrote:
>
>> In the undo path of start_isolate_page_range(), we need to check
>> the pfn validity before access its page, or it will trigger an
>> addressing exception if there is hole in the zone.
>>
>
> There is not enough information in the chagnelog for me to decide how
> to handle the patch.  3.19?  3.18? 3.18+stable?
>
> When fixing bugs, please remember to fully explain the end-user impact
> of the bug.  Under what circumstances does it occur?

I'm sorry to disturb you. This issue is found by code-review not a test-trigger.
In "CONFIG_HOLES_IN_ZONE" environment, there is a certain chance that
it would casue an addressing exception when start_isolate_page_range() fails,
this could affect CMA, hugepage and memory-hotplug function.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/