linux-kernel - [PATCH v3 0/2] Fix node meminfo and zoneinfo corruption.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1415781434-20230-1-git-send-email-tangchen@cn.fujitsu.com>
Date:	Wed, 12 Nov 2014 16:37:12 +0800
From:	Tang Chen <tangchen@...fujitsu.com>
To:	<akpm@...ux-foundation.org>, <grygorii.strashko@...com>,
	<yinghai@...nel.org>, <isimatu.yasuaki@...fujitsu.com>,
	<fabf@...net.be>, <nzimmer@....com>, <wangnan0@...wei.com>,
	<vdavydov@...allels.com>, <toshi.kani@...com>,
	<phacht@...ux.vnet.ibm.com>, <tj@...nel.org>,
	<kirill.shutemov@...ux.intel.com>, <riel@...hat.com>,
	<luto@...capital.net>, <hpa@...ux.intel.com>,
	<aarcange@...hat.com>, <qiuxishi@...wei.com>, <mgorman@...e.de>,
	<rientjes@...gle.com>, <hannes@...xchg.org>
CC:	<linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>,
	<tangchen@...fujitsu.com>
Subject: [PATCH v3 0/2] Fix node meminfo and zoneinfo corruption.

There are two problems in memory hot-add progress:

1. When hot-adding a node without onlining any page, node meminfo corrupted:

# hot-add node2 (memory not onlined)
# cat /sys/device/system/node/node2/meminfo
Node 2 MemTotal:       33554432 kB			/* corrupted */
Node 2 MemFree:               0 kB
Node 2 MemUsed:        33554432 kB
Node 2 Active:                0 kB
......


2. When onlining memory on node2, node2 zoneinfo and node3 meminfo corrupted:

# for ((i = 2048; i < 2064; i++)); do echo online_movable > /sys/devices/system/node/node2/memory$i/state; done
# cat /sys/devices/system/node/node2/meminfo
Node 2 MemTotal:       33554432 kB
Node 2 MemFree:        33549092 kB
Node 2 MemUsed:            5340 kB
......
# cat /sys/devices/system/node/node3/meminfo
Node 3 MemTotal:              0 kB
Node 3 MemFree:               248 kB      /* corrupted, should be 0 */
Node 3 MemUsed:               0 kB
......

# cat /proc/zoneinfo
......
Node 2, zone   Movable
......
        spanned  8388608
        present  16777216		/* corrupted, should be 8388608 */
        managed  8388608


Change log v2 -> v3:
1. Also clear pgdat->node_present_pages in patch 2/2.
2. Add Cc: stable@...r.kernel.org # 3.16+ since it is urgent.

Change log v1 -> v2:
1. Replace patch 2/2 with a new one. It provides the simplest way to
   fix problem 2. 

Tang Chen (2):
  mem-hotplug: Reset node managed pages when hot-adding a new pgdat.
  mem-hotplug: Reset node present pages when hot-adding a new pgdat.

 include/linux/bootmem.h |  1 +
 mm/bootmem.c            |  9 +++++----
 mm/memory_hotplug.c     | 26 ++++++++++++++++++++++++++
 mm/nobootmem.c          |  8 +++++---
 4 files changed, 37 insertions(+), 7 deletions(-)

-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/