linux-kernel - Re: [PATCH V2 2/2] PCI: generic: Add msi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54634627.60502@amd.com>
Date:	Wed, 12 Nov 2014 18:36:07 +0700
From:	Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
To:	Srikanth Thokala <sriku.linux@...il.com>
CC:	Bjorn Helgaas <bhelgaas@...gle.com>, <liviu.dudau@....com>,
	<lorenzo.pieralisi@....com>, <will.deacon@....com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2 2/2] PCI: generic: Add msi_parent DT binding

On 11/12/14 13:56, Srikanth Thokala wrote:
>> @@ -122,9 +123,19 @@ static int gen_pci_config_write(struct pci_bus *bus, unsigned int devfn,
>> >         return PCIBIOS_SUCCESSFUL;
>> >  }
>> >
>> >+static int gen_pci_set_msi_parent(struct pci_bus *bus)
>> >+{
>> >+       struct gen_pci *pci = bus_to_gen_pci(bus);
>> >+
>> >+       bus->msi = pci->mchip;
>> >+
>> >+       return PCIBIOS_SUCCESSFUL;
>> >+}
>> >+
>> >  static struct pci_ops gen_pci_ops = {
>> >         .read   = gen_pci_config_read,
>> >         .write  = gen_pci_config_write,
>> >+       .set_msi_parent = gen_pci_set_msi_parent,
> We assign the msi chip through add_bus() call, do we still need this?

Certain architecture (i.e arm64) doesn't implement struct hw_pci. 
Therefore, there is no add_bus().  However, this new API should allow 
non-arch dependent implementation.

Suravee
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/