[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAAObsKCxZvZE_3DOW3KXJUtdqy6s-vVYLQMzmQGLiurPsPjxWg@mail.gmail.com>
Date: Thu, 13 Nov 2014 10:36:05 +0100
From: Tomeu Vizoso <tomeu.vizoso@...labora.com>
To: Thierry Reding <thierry.reding@...il.com>
Cc: "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
Javier Martinez Canillas <javier.martinez@...labora.co.uk>,
Mikko Perttunen <mikko.perttunen@...si.fi>,
Alexandre Courbot <acourbot@...dia.com>,
Rob Herring <robh+dt@...nel.org>,
Pawel Moll <pawel.moll@....com>,
Mark Rutland <mark.rutland@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>,
Stephen Warren <swarren@...dotorg.org>,
Alexandre Courbot <gnurou@...il.com>,
Peter De Schrijver <pdeschrijver@...dia.com>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 04/13] of: document new emc-timings subnode in nvidia,tegra124-car
On 12 November 2014 15:18, Thierry Reding <thierry.reding@...il.com> wrote:
> On Wed, Nov 12, 2014 at 08:56:27AM +0100, Tomeu Vizoso wrote:
> [...]
>> Example SoC include file:
>>
>> / {
>> - tegra_car: clock {
>> + tegra_car: clock@...06000 {
>> compatible = "nvidia,tegra124-car";
>> reg = <0x60006000 0x1000>;
>> #clock-cells = <1>;
>> @@ -60,4 +83,23 @@ Example board file:
>> &tegra_car {
>> clocks = <&clk_32k> <&osc>;
>> };
>> +
>> + clock@...06000 {
>> + emc-timings@3 {
>
> Shouldn't this be following the same naming scheme as the memory
> controller's subnodes?
>
>> + nvidia,ram-code = <3>;
>> +
>> + timing@...50000 {
>
> And this?
Thanks for pointing these out. My bad.
Regards,
Tomeu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists