linux-kernel - Re: BUG() at boot in __phys_addr with DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1415884083.14686.439.camel@mfleming-mobl1.ger.corp.intel.com>
Date:	Thu, 13 Nov 2014 13:08:03 +0000
From:	Matt Fleming <matt.fleming@...el.com>
To:	Dave Hansen <dave.hansen@...el.com>
CC:	Borislav Petkov <bp@...e.de>,
	the arch/x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: BUG() at boot in __phys_addr with DEBUG_VIRTUAL

On Wed, 2014-11-12 at 07:20 -0800, Dave Hansen wrote:
> 
> The path that we're actually hitting this from is:
> 
> > __split_large_page(struct cpa_data *cpa, pte_t *kpte, unsigned long
> ...
> >         if (pfn_range_is_mapped(PFN_DOWN(__pa(address)),
> >                                 PFN_DOWN(__pa(address)) + 1))
> >                 split_page_count(level);

I'm sure I'm just being dumb, but I can't for the life of me work out
why we need to calculate the physical address from the virtual address
at this point - we should already have that information.

> So perhaps efi_map_region() is handing an address from the EFI identity
> map down in here.  __pa() gets called on it, but that fails since __pa()
> only works on the *KERNEL* identity map.

Yep, sounds right.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/