linux-kernel - Re: [PATCH] mm/zswap: add __init to some functions in zswap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADAEsF-LvMCm0SA4PY4f66rwJGWiyR6OWHG2vaagSPQ1LrQ0GQ@mail.gmail.com>
Date:	Thu, 13 Nov 2014 22:16:10 +0800
From:	Ganesh Mahendran <opensource.ganesh@...il.com>
To:	Seth Jennings <sjennings@...iantweb.net>
Cc:	Minchan Kim <minchan@...nel.org>, ddstreet@...e.org,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/zswap: add __init to some functions in zswap

2014-11-13 10:55 GMT+08:00 Seth Jennings <sjennings@...iantweb.net>:
> On Sun, Nov 09, 2014 at 08:23:52PM +0800, Mahendran Ganesh wrote:
>> zswap_cpu_init/zswap_comp_exit/zswap_entry_cache_create is only
>> called by __init init_zswap()
>
> Thanks for the cleanup!
>
> Acked-by: Seth Jennings <sjennings@...iantweb.net>

Thanks very much!

>
>>
>> Signed-off-by: Mahendran Ganesh <opensource.ganesh@...il.com>
>> ---
>>  mm/zswap.c |    6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/mm/zswap.c b/mm/zswap.c
>> index 51a2c45..2e621fa 100644
>> --- a/mm/zswap.c
>> +++ b/mm/zswap.c
>> @@ -149,7 +149,7 @@ static int __init zswap_comp_init(void)
>>       return 0;
>>  }
>>
>> -static void zswap_comp_exit(void)
>> +static void __init zswap_comp_exit(void)
>>  {
>>       /* free percpu transforms */
>>       if (zswap_comp_pcpu_tfms)
>> @@ -206,7 +206,7 @@ static struct zswap_tree *zswap_trees[MAX_SWAPFILES];
>>  **********************************/
>>  static struct kmem_cache *zswap_entry_cache;
>>
>> -static int zswap_entry_cache_create(void)
>> +static int __init zswap_entry_cache_create(void)
>>  {
>>       zswap_entry_cache = KMEM_CACHE(zswap_entry, 0);
>>       return zswap_entry_cache == NULL;
>> @@ -389,7 +389,7 @@ static struct notifier_block zswap_cpu_notifier_block = {
>>       .notifier_call = zswap_cpu_notifier
>>  };
>>
>> -static int zswap_cpu_init(void)
>> +static int __init zswap_cpu_init(void)
>>  {
>>       unsigned long cpu;
>>
>> --
>> 1.7.9.5
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/