linux-kernel - Re: [PATCH 3.17 023/319] drivers/net: Disable UFO through virtio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1415903703.3398.115.camel@decadent.org.uk>
Date:	Thu, 13 Nov 2014 18:35:03 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 3.17 023/319] drivers/net: Disable UFO through virtio

On Thu, 2014-11-13 at 18:48 +0100, Jiri Slaby wrote:
> On 11/12/2014, 10:03 PM, Ben Hutchings wrote:
> > On Wed, 2014-11-12 at 10:12 +0900, Greg Kroah-Hartman wrote:
> >> 3.17-stable review patch.  If anyone has any objections, please
> >> let me know.
> >> 
> >> ------------------
> >> 
> >> From: Ben Hutchings <ben@...adent.org.uk>
> >> 
> >> [ Upstream commit 3d0ad09412ffe00c9afa201d01effdb6023d09b4 ]
> >> 
> >> IPv6 does not allow fragmentation by routers, so there is no 
> >> fragmentation ID in the fixed header.  UFO for IPv6 requires the
> >> ID to be passed separately, but there is no provision for this in
> >> the virtio net protocol.
> >> 
> >> Until recently our software implementation of UFO/IPv6 generated
> >> a new ID, but this was a bug.  Now we will use ID=0 for any
> >> UFO/IPv6 packet passed through a tap, which is even worse.
> >> 
> >> Unfortunately there is no distinction between UFO/IPv4 and v6 
> >> features, so disable UFO on taps and virtio_net completely until
> >> we have a proper solution.
> > [...]
> > 
> > Please drop this patch for 3.14 and 3.17.  It causes problems for 
> > migration of VMs and we're probably going to revert part of this.
> > The following patch ("drivers/net, ipv6: Select IPv6 fragment
> > idents for virtio UFO packets") might no longer apply, in which
> > case you can drop that as well until we have this sorted out
> > upstream.
> 
> The same holds for 3.12, I suppose?

Right.

Ben.

-- 
Ben Hutchings
friends: People who know you well, but like you anyway.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)