linux-kernel - Re: [PATCH 06/16] assoc_array: Replace smp_read_barrier_depends() with lockless

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24280.1415909476@warthog.procyon.org.uk>
Date:	Thu, 13 Nov 2014 20:11:16 +0000
From:	David Howells <dhowells@...hat.com>
To:	Pranith Kumar <bobby.prani@...il.com>
Cc:	dhowells@...hat.com, James Morris <james.l.morris@...cle.com>,
	"Serge E. Hallyn" <serge@...lyn.com>,
	Stephen Hemminger <shemming@...cade.com>,
	Andreea-Cristina Bernat <bernat.ada@...il.com>,
	linux-kernel@...r.kernel.org (open list),
	keyrings@...ux-nfs.org (open list:KEYS/KEYRINGS:),
	linux-security-module@...r.kernel.org (open list:SECURITY SUBSYSTEM),
	paulmck@...ux.vnet.ibm.com
Subject: Re: [PATCH 06/16] assoc_array: Replace smp_read_barrier_depends() with lockless_dereference()

Pranith Kumar <bobby.prani@...il.com> wrote:

>  static inline bool assoc_array_ptr_is_meta(const struct assoc_array_ptr *x)
>  {
> -	return (unsigned long)x & ASSOC_ARRAY_PTR_TYPE_MASK;
> +	return (unsigned long)lockless_dereference(x) &
> +						ASSOC_ARRAY_PTR_TYPE_MASK;
>  }

Nack.  x is not being dereferenced here, nor in some of the other places
you've added this.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/