linux-kernel - Re: [PATCH] devcoredump: provide a one-way disable function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1415918185.19075.1.camel@sipsolutions.net>
Date:	Thu, 13 Nov 2014 23:36:25 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Kees Cook <keescook@...gle.com>
Cc:	Greg Kroah-Hartmann <gregkh@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] devcoredump: provide a one-way disable function

On Thu, 2014-11-13 at 13:56 -0800, Kees Cook wrote:

> > +       /*
> > +        * This essentially makes the attribute write-once, since you can't
> > +        * go back to not having it disabled. This is intentional, it serves
> > +        * as a system lockdown feature.
> > +        */
> > +       if (tmp != 1)
> > +               return -EINVAL;
> 
> Just a nit, but writing "0" is valid if devcd_disabled = false?

I thought about that too, but what would the point be? The only
operation you ever can/want to do is writing "1" to it to disable the
framework.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/