[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5465BFA2.9050706@nvidia.com>
Date: Fri, 14 Nov 2014 17:38:58 +0900
From: Alexandre Courbot <acourbot@...dia.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
Mark Brown <broonie@...nel.org>,
Mark Rutland <mark.rutland@....com>
CC: Simon Horman <horms@...ge.net.au>, Joe Perches <joe@...ches.com>,
"Geert Uytterhoeven" <geert@...ux-m68k.org>,
Kuninori Morimoto <kuninori.morimoto.gx@...il.com>,
Olof Johansson <olof@...om.net>,
"Stephen Warren" <swarren@...dotorg.org>,
Rob Herring <robh@...nel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"ALSA Development Mailing List" <alsa-devel@...a-project.org>,
Linux-sh list <linux-sh@...r.kernel.org>,
Magnus <magnus.damm@...il.com>,
"grant.likely@...aro.org" <grant.likely@...aro.org>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-tegra@...r.kernel.org>
Subject: Re: [PATCH v3] of: replace Asahi Kasei Corp venter prefix
On 11/14/2014 10:43 AM, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
>
> Current vendor-prefixes.txt already has
> "ak" prefix for Asahi Kasei Corp by
> ae8c4209af2cec065fef15d200a42a04130799f7
> (of: Add vendor prefix for Asahi Kasei Corp.)
>
> It went through the appropriate review process.
> But, almost all Asahi Kasei chip drivers are
> using "asahi-kasei" prefix today.
> (arch/arm/boot/dts/tegra20-seaboard.dts only is
> using "ak,ak8975", but there are instances of
> "asahi-kasei,ak8975" in other dts files.
> And drivers/iio/magnetometer/ak8975.c
> doesn't support "ak,ak8975")
> So, we made a mistake there.
>
> In addition, checkpatch.pl reports WARNING
> if it is using "asahi-kasei" prerfix in DT file.
> (DT compatible string vendor "asahi-kasei" appears un-documented)
>
> Marking it deprecated and warning with checkpatch
> is certainly preferable.
> So, this patch replace "ak" to "asahi-kasei" in
> vendor-prefixes.txt. (and fixup tegra20-seaboard)
>
> OTOH, Asahi Kasei is usually referred to as "AKM",
> but this patch doesn't care about it.
> Because no DT is using that today.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
> ---
> .../devicetree/bindings/vendor-prefixes.txt | 2 +-
> arch/arm/boot/dts/tegra20-seaboard.dts | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index 723999d..ddcb4cd 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -9,7 +9,6 @@ ad Avionic Design GmbH
> adapteva Adapteva, Inc.
> adi Analog Devices, Inc.
> aeroflexgaisler Aeroflex Gaisler AB
> -ak Asahi Kasei Corp.
> allwinner Allwinner Technology Co., Ltd.
> altr Altera Corp.
> amcc Applied Micro Circuits Corporation (APM, formally AMCC)
> @@ -20,6 +19,7 @@ amstaos AMS-Taos Inc.
> apm Applied Micro Circuits Corporation (APM)
> arm ARM Ltd.
> armadeus ARMadeus Systems SARL
> +asahi-kasei Asahi Kasei Corp.
> atmel Atmel Corporation
> auo AU Optronics Corporation
> avago Avago Technologies
> diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts
> index a1d4bf9..7f5cf80 100644
> --- a/arch/arm/boot/dts/tegra20-seaboard.dts
> +++ b/arch/arm/boot/dts/tegra20-seaboard.dts
> @@ -405,7 +405,7 @@
> clock-frequency = <400000>;
>
> magnetometer@c {
> - compatible = "ak,ak8975";
> + compatible = "asahi-kasei,ak8975";
Mmm. So does this mean this device was never probed because the driver
did not recognize its compatible property? I cannot find "ak,ak8975"
anywhere else in the kernel.
If so,
Acked-by: Alexandre Courbot <acourbot@...dia.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists