linux-kernel - Re: [RFC][PATCH 12/23 v4] tracing: Remove return values of most trace_seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141114112152.25542b93@gandalf.local.home>
Date:	Fri, 14 Nov 2014 11:21:52 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Petr Mladek <pmladek@...e.cz>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jiri Kosina <jkosina@...e.cz>
Subject: Re: [RFC][PATCH 12/23 v4] tracing: Remove return values of most
 trace_seq_*() functions

On Fri, 14 Nov 2014 09:53:39 -0500
Steven Rostedt <rostedt@...dmis.org> wrote:


> > > @@ -334,10 +297,7 @@ int trace_seq_putmem_hex(struct trace_seq *s, const void *mem,
> > >  		/* j increments twice per loop */
> > >  		len -= j / 2;
> > >  		hex[j++] = ' ';
> > > -
> > > -		cnt += trace_seq_putmem(s, hex, j);
> > 
> > trace_seq_putmem(s, hex, j); should stay ;-)
> 
> Ouch! Looks like I got a little happy with the delete line key stroke.
> 
> Good catch!
> 

And in the end it really didn't matter, as the patch "tracing: Create
seq_buf layer in trace_seq" took all this out.

I'll still update the patch for correctness.

Thanks,

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/