linux-kernel - Re: [PATCH 09/11] x86, mpx: on-demand kernel allocation of bounds tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54663790.4030308@sr71.net>
Date:	Fri, 14 Nov 2014 09:10:40 -0800
From:	Dave Hansen <dave@...1.net>
To:	Thomas Gleixner <tglx@...utronix.de>
CC:	hpa@...or.com, mingo@...hat.com, x86@...nel.org,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	linux-ia64@...r.kernel.org, linux-mips@...ux-mips.org,
	qiaowei.ren@...el.com, dave.hansen@...ux.intel.com
Subject: Re: [PATCH 09/11] x86, mpx: on-demand kernel allocation of bounds
 tables

On 11/14/2014 08:47 AM, Thomas Gleixner wrote:
> On Fri, 14 Nov 2014, Dave Hansen wrote:
>>  * move mm init-time #ifdef to mpx.h
> 
>> +static inline void arch_bprm_mm_init(struct mm_struct *mm,
>> +		struct vm_area_struct *vma)
>> +{
>> +	mpx_mm_init(mm);
>> +#ifdef CONFIG_X86_INTEL_MPX
>> +	mm->bd_addr = MPX_INVALID_BOUNDS_DIR;
>> +#endif
> 
> So we have a double init now :)

Bah, that kinda defeats the purpose now, doesn't it? :)

>> +++ b/arch/x86/kernel/setup.c	2014-11-14 07:06:23.941684394 -0800
>> @@ -959,6 +959,13 @@ void __init setup_arch(char **cmdline_p)
>>  	init_mm.end_code = (unsigned long) _etext;
>>  	init_mm.end_data = (unsigned long) _edata;
>>  	init_mm.brk = _brk_end;
>> +#ifdef CONFIG_X86_INTEL_MPX
>> +	/*
>> +	 * NULL is theoretically a valid place to put the bounds
>> +	 * directory, so point this at an invalid address.
>> +	 */
>> +	init_mm.bd_addr = MPX_INVALID_BOUNDS_DIR;
>> +#endif
> 
> And this one wants mpx_mm_init() replacement as well.

Rather than reposting the whole set, attached is a quick redo of the
changes to just this patch.

If anyone wants the whole thing resent, or this one in another format,
please holler.

View attachment "mpx-v11-on-demand-kernel-allocation-of-bounds-tables.patch" of type "text/x-patch" (25987 bytes)