linux-kernel - Re: [PATCH v2] virtio_balloon: Convert "vballon" kthread into a workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141114174252.GE7969@dhcp128.suse.cz>
Date:	Fri, 14 Nov 2014 18:42:52 +0100
From:	Petr Mladek <pmladek@...e.cz>
To:	Tejun Heo <tj@...nel.org>
Cc:	"Michael S. Tsirkin" <mst@...hat.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Jiri Kosina <jkosina@...e.cz>,
	virtualization@...ts.linux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] virtio_balloon: Convert "vballon" kthread into a
 workqueue

On Fri 2014-11-14 08:19:15, Tejun Heo wrote:
> Hello, Michael, Petr.
> 
> On Wed, Nov 12, 2014 at 03:32:04PM +0200, Michael S. Tsirkin wrote:
> > > +	/* The workqueue servicing the balloon. */
> > > +	struct workqueue_struct *wq;
> > > +	struct work_struct wq_work;
> > 
> > We could use system_freezable_wq instead.
> > I do agree a dedicated wq is better since this can get blocked
> > for a long time while allocating memory.
> > However, please add a comment to this effect.
> 
> system_freezable_wq should be fine.  Workqueues by default have a
> pretty high maximum concurrency level (256).  There's no reason to
> create separate workqueues solely for that purpose.

Great. If nobody complains until next week, I will send an updated
patch with the system workqueue and also with the fixed typos.

Thanks all reviewers for nice hints.

Best Regards,
Petr
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/