[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <54664C0B.6070604@sr71.net>
Date: Fri, 14 Nov 2014 10:38:03 -0800
From: Dave Hansen <dave@...1.net>
To: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>, hpa@...or.com
CC: tglx@...utronix.de, mingo@...hat.com, x86@...nel.org,
linux-mm@...ck.org, linux-kernel@...r.kernel.org,
linux-ia64@...r.kernel.org, linux-mips@...ux-mips.org,
qiaowei.ren@...el.com, dave.hansen@...ux.intel.com
Subject: Re: [PATCH 05/11] x86, mpx: add MPX to disaabled features
On 11/14/2014 09:56 AM, Sergei Shtylyov wrote:
>> #define DISABLED_MASK6 0
>> #define DISABLED_MASK7 0
>> #define DISABLED_MASK8 0
>> -#define DISABLED_MASK9 0
>> +#define DISABLED_MASK9 (DISABLE_MPX)
>
> These parens are not really needed. Sorry to be a PITA and not saying
> this before.
One goal of the disabled features patch was to maintain parity with
required-features.h. It declares things this way:
> #define REQUIRED_MASK3 (NEED_NOPL)
> #define REQUIRED_MASK4 (NEED_MOVBE)
So, no, those aren't strictly needed, but there is precedent for them
and they do no harm. I think I'll leave them as-is.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists