| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <47990659.56515.1415993549555.open-xchange@webmail.nmp.skynet.be> Date: Fri, 14 Nov 2014 20:32:29 +0100 (CET) From: Fabian Frederick <fabf@...net.be> To: Joe Perches <joe@...ches.com> Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, "David S. Miller" <davem@...emloft.net> Subject: Re: [PATCH 1/1 net-next] net: dsa: replace count*size kmalloc by kmalloc_array > On 14 November 2014 at 20:14 Joe Perches <joe@...ches.com> wrote: > > > On Fri, 2014-11-14 at 20:02 +0100, Fabian Frederick wrote: > > On 14 November 2014 at 19:47 Joe Perches <joe@...ches.com> wrote: > > > On Fri, 2014-11-14 at 19:36 +0100, Fabian Frederick wrote: > > > > kmalloc_array manages count*sizeof overflow. > > > > > > Fundamentally correct, but is this necessary or useful? > > > sizeof(s8) isn't often going to be anything other than 1. > > Absolutely, I thought it was a struct :) > > > > There must be a reason for so many cases though ... > > Some might be style symmetry for other sizeof(othertype) > uses in the same paths, but most of them are just overkill > or maybe lack of understanding. > > s8 is char so by definition it has to be 1. > > I doubt any of the code dates from PDP-8/TOPS-10 days. > > 95% comes from drivers tree. I guess one patch to Greg would be enough. Are you interested in those patches or can I do them with some "Suggested-by" ? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists