linux-kernel - Re: [PATCH] printk: drop logbuf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141114145533.633457c3@gandalf.local.home>
Date:	Fri, 14 Nov 2014 14:55:33 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Alex Elder <elder@...aro.org>
Cc:	akpm@...ux-foundation.org, bobby.prani@...il.com, pmladek@...e.cz,
	jack@...e.cz, mcgrof@...e.com, joe@...ches.com,
	linux-kernel@...r.kernel.org, Jiri Kosina <jkosina@...e.cz>
Subject: Re: [PATCH] printk: drop logbuf_cpu volatile qualifier

On Fri, 14 Nov 2014 13:46:44 -0600
Alex Elder <elder@...aro.org> wrote:

> On 11/14/2014 01:45 PM, Steven Rostedt wrote:
> > On Fri, 14 Nov 2014 13:19:31 -0600
> > Alex Elder <elder@...aro.org> wrote:
> > 
> >> Pranith Kumar posted a patch in which removed the "volatile"
> >> qualifier for the "logbuf_cpu" variable in vprintk_emit().
> >>     https://lkml.org/lkml/2014/11/13/894
> >> In his patch, he used ACCESS_ONCE() for all references to
> >> that symbol to provide whatever protection was intended.
> >>
> >> There was some discussion that followed, and in the end
> >> Stephen Rostedt concluded that not only was "volatile" not
> > 
> > I don't know of a Stephen Rostedt. J
> 
> Sorry.  I'm sure that's a source of annoyance.  -Alex

No problem. If you are wondering about that "J".

  https://www.facebook.com/mcgrof/posts/10104459749108919

It's my new thing. Maybe I can start a trend. J

-- Steve

> 
> >> needed, neither was it required to use ACCESS_ONCE().  I
> >> offered an elaborate description that concluded Stephen
> > 
> > Who is this Stephen you talk about?
> 
> . . .

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/