linux-kernel - Re: [PATCH] gpio-tz1090: fix error handling of irq_of_parse_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141114235307.GF1739@jhogan-linux.le.imgtec.org>
Date:	Fri, 14 Nov 2014 23:53:07 +0000
From:	James Hogan <james.hogan@...tec.com>
To:	Dmitry Torokhov <dtor@...omium.org>
CC:	Linus Walleij <linus.walleij@...aro.org>,
	Alexandre Courbot <gnurou@...il.com>,
	Wolfram Sang <wsa@...-dreams.de>, <linux-gpio@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio-tz1090: fix error handling of irq_of_parse_and_map

On Fri, Nov 14, 2014 at 01:32:56PM -0800, Dmitry Torokhov wrote:
> irq_of_parse_and_map() returns 0 on error, so testing for negative
> result never works.
> 
> Signed-off-by: Dmitry Torokhov <dtor@...omium.org>

Good catch, thanks!

Acked-by: James Hogan <james.hogan@...tec.com>

A quick coccinelle script shows up numerous other cases of this error
around the kernel tree too...

Cheers
James

> ---
> 
> Not tested, found by casual inspection of the code.
> 
>  drivers/gpio/gpio-tz1090.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpio-tz1090.c b/drivers/gpio/gpio-tz1090.c
> index 9e90177..e3024bb 100644
> --- a/drivers/gpio/gpio-tz1090.c
> +++ b/drivers/gpio/gpio-tz1090.c
> @@ -446,7 +446,7 @@ static int tz1090_gpio_bank_probe(struct tz1090_gpio_bank_info *info)
>  	bank->irq = irq_of_parse_and_map(np, 0);
>  
>  	/* The interrupt is optional (it may be used by another core on chip) */
> -	if (bank->irq < 0) {
> +	if (!bank->irq) {
>  		dev_info(dev, "IRQ not provided for bank %u, IRQs disabled\n",
>  			 info->index);
>  		return 0;
> -- 
> 2.1.0.rc2.206.gedb03e5
> 
> 
> -- 
> Dmitry

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)