linux-kernel - Re: [PATCH] genirq: Add IRQ 0 to domain debug file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 15 Nov 2014 21:01:57 +0800
From:	Jiang Liu <jiang.liu@...ux.intel.com>
To:	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Thomas Gleixner <tglx@...utronix.de>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] genirq: Add IRQ 0 to domain debug file

On 2014/11/15 19:27, Dmitry Eremin-Solenikov wrote:
> Currently irq_domain_mapping debugfs file dumps IRQ information starting
> from IRQ 1. IRQ 0 is missing from that file. Add it to have the complete
> picture of IRQ/domains mappings.
Hi Dmitry,
	For most irqdomain interfaces, they treat irq0 as invalid
interrupt. But on x86, it's possible to use irq0 for timer. It causes
may confusion when enabling irqdomain for x86.
Regards!
Gerry

> 
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@...il.com>
> ---
>  kernel/irq/irqdomain.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index 6534ff6..0e0c7a8 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -585,7 +585,7 @@ static int virq_debug_show(struct seq_file *m, void *private)
>  		      "chip name", (int)(2 * sizeof(void *) + 2), "chip data",
>  		      "active", "type", "domain");
>  
> -	for (i = 1; i < nr_irqs; i++) {
> +	for (i = 0; i < nr_irqs; i++) {
>  		desc = irq_to_desc(i);
>  		if (!desc)
>  			continue;
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/