| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <546899CF.8020808@users.sourceforge.net> Date: Sun, 16 Nov 2014 13:34:23 +0100 From: SF Markus Elfring <elfring@...rs.sourceforge.net> To: Ananth N Mavinakayanahalli <ananth@...ibm.com>, Anil S Keshavamurthy <anil.s.keshavamurthy@...el.com>, "David S. Miller" <davem@...emloft.net>, Masami Hiramatsu <masami.hiramatsu.pt@...achi.com> CC: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org, Coccinelle <cocci@...teme.lip6.fr> Subject: [PATCH 1/1] kprobes: Deletion of an unnecessary check before the function call "module_put" From: Markus Elfring <elfring@...rs.sourceforge.net> Date: Sun, 16 Nov 2014 12:20:31 +0100 The module_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net> --- kernel/kprobes.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/kprobes.c b/kernel/kprobes.c index 3995f54..f1e7d45 100644 --- a/kernel/kprobes.c +++ b/kernel/kprobes.c @@ -1527,8 +1527,7 @@ int register_kprobe(struct kprobe *p) out: mutex_unlock(&kprobe_mutex); - if (probed_mod) - module_put(probed_mod); + module_put(probed_mod); return ret; } -- 2.1.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists