linux-kernel - Re: [PATCH V3] ARM: tegra: Re-add removed SoC id macro to tegra

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141117110715.GB25699@ulmo>
Date:	Mon, 17 Nov 2014 12:07:16 +0100
From:	Thierry Reding <thierry.reding@...il.com>
To:	Dmitry Osipenko <digetx@...il.com>
Cc:	swarren@...dotorg.org, josephl@...dia.com, balbi@...com,
	linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH V3] ARM: tegra: Re-add removed SoC id macro to
 tegra_resume()

On Fri, Oct 10, 2014 at 05:24:47PM +0400, Dmitry Osipenko wrote:
> Commit d127e9c ("ARM: tegra: make tegra_resume can work with current and later
> chips") removed tegra_get_soc_id macro leaving used cpu register corrupted after
> branching to v7_invalidate_l1() and as result causing execution of unintended
> code on tegra20. Possibly it was expected that r6 would be SoC id func argument
> since common cpu reset handler is setting r6 before branching to tegra_resume(),
> but neither tegra20_lp1_reset() nor tegra30_lp1_reset() aren't setting r6
> register before jumping to resume function. Fix it by re-adding macro.
> 
> Fixes: d127e9c (ARM: tegra: make tegra_resume can work with current and later chips)
> Cc: <stable@...r.kernel.org> # v3.13+
> Reviewed-by: Felipe Balbi <balbi@...com>
> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
> ---
> V2: added Cc's for lakml and stable, added "Reviewed-by:" Felipe Balbi
> V3: changed commit description, tested on real hw
> 
> PS: It wasn't a bug in my emulator :)
> 
>  arch/arm/mach-tegra/reset-handler.S | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

Thierry

Content of type "application/pgp-signature" skipped