| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <5469FB58.4070205@users.sourceforge.net> Date: Mon, 17 Nov 2014 14:42:48 +0100 From: SF Markus Elfring <elfring@...rs.sourceforge.net> To: linux-kernel@...r.kernel.org CC: kernel-janitors@...r.kernel.org, Coccinelle <cocci@...teme.lip6.fr> Subject: [PATCH 1/1] tools lib traceevent: Deletion of an unnecessary check before the function call "free_arg" From: Markus Elfring <elfring@...rs.sourceforge.net> Date: Mon, 17 Nov 2014 14:38:14 +0100 The free_arg() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net> --- tools/lib/traceevent/parse-filter.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/lib/traceevent/parse-filter.c b/tools/lib/traceevent/parse-filter.c index b502344..78debaf 100644 --- a/tools/lib/traceevent/parse-filter.c +++ b/tools/lib/traceevent/parse-filter.c @@ -1237,8 +1237,7 @@ filter_event(struct event_filter *filter, struct event_format *event, if (filter_type == NULL) return PEVENT_ERRNO__MEM_ALLOC_FAILED; - if (filter_type->filter) - free_arg(filter_type->filter); + free_arg(filter_type->filter); filter_type->filter = arg; return 0; -- 2.1.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists