linux-kernel - Re: [RESUBMIT PATCH v7 7/9] regulator: sky81452: Modify Device Tree structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141117141836.GA2722@sirena.org.uk>
Date:	Mon, 17 Nov 2014 14:18:36 +0000
From:	Mark Brown <broonie@...nel.org>
To:	gyungoh@...il.com
Cc:	sameo@...ux.intel.com, lee.jones@...aro.org, jg1.han@...sung.com,
	cooloney@...il.com, lgirdwood@...il.com, jack.yoo@...worksinc.com,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	grant.likely@...aro.org, robh+dt@...nel.org, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	pawel.moll@....com, heiko@...ech.de, jason@...edaemon.net,
	shawn.guo@...escale.com, treding@...dia.com,
	florian.vaussard@...l.ch, trivial@...nel.org, linux@...ck-us.net,
	andrew@...n.ch, jic23@...nel.org
Subject: Re: [RESUBMIT PATCH v7 7/9] regulator: sky81452: Modify Device Tree
 structure

On Mon, Nov 17, 2014 at 05:33:08PM +0900, gyungoh@...il.com wrote:

>  	np = of_get_child_by_name(dev->parent->of_node, "regulator");

> +	ret = of_regulator_match(dev, np, &sky81452_match, 1);

Don't open code this, use regulators_node and of_match as previously
advised.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)