linux-kernel - Re: [PATCH v3 0/3] Amlogic Meson pinctrl driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 17 Nov 2014 10:57:45 -0800
From:	Sören Brinkmann <soren.brinkmann@...inx.com>
To:	Beniamino Galvani <b.galvani@...il.com>
CC:	Linus Walleij <linus.walleij@...aro.org>,
	<linux-gpio@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
	Arnd Bergmann <arnd@...db.de>,
	Russell King <linux@....linux.org.uk>,
	Carlo Caione <carlo@...one.org>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Jerry Cao <jerry.cao@...ogic.com>,
	Victor Wan <victor.wan@...ogic.com>
Subject: Re: [PATCH v3 0/3] Amlogic Meson pinctrl driver

Hi Beniamino,

On Sun, 2014-11-16 at 09:14PM +0100, Beniamino Galvani wrote:
> Hi,
> 
> this is the third version of the pinctrl driver for Amlogic Meson. It
> provides a common infrastructure than can be used by all the SoCs of
> the family and configuration data specific for Meson8. Adding support
> for other SoCs should be only matter of defining new pins and banks.
> 
> The driver uses generic DT properties for the definition of mux and
> configuration nodes; since there is an ongoing effort to centralize
> the parsing to generic code, I've reused the patch "pinctrl:
> pinconf-generic: Infer map type from DT property" [1] posted a few
> days ago by Soren Brinkmann. I will update the series if that patch is
> going to change after the mailing list discussion.

Looks really nice to me and it's great that you use my patch as basis.
Looks like it works for more people than just me :)
I hope we can convince Linus to take that patch more or less as is. Even
though "kludgy" I don't see an easy way for addressing Linus' comments
without breaking current users of the interface. It may be easier/better
to gradually migrate to the newly defined bindings and remove the
kludgyness as user that rely on the current behavior disappear.

	Thanks,
	Sören
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/