linux-kernel - Re: [PATCH] crypto: prefix module autoloading with "crypto-"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jK4vu0uJ2R+MjLfjhrMBOqoLcE_3=e-T=ea=u_ZzSatqw@mail.gmail.com>
Date:	Mon, 17 Nov 2014 11:43:30 -0800
From:	Kees Cook <keescook@...omium.org>
To:	Mathias Krause <minipli@...glemail.com>
Cc:	Herbert Xu <herbert@...dor.apana.org.au>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>
Subject: Re: [PATCH] crypto: prefix module autoloading with "crypto-"

On Mon, Nov 17, 2014 at 10:38 AM, Mathias Krause <minipli@...glemail.com> wrote:
> On 17 November 2014 16:09, Herbert Xu <herbert@...dor.apana.org.au> wrote:
>> On Fri, Nov 14, 2014 at 01:34:59PM -0800, Kees Cook wrote:
>>> This prefixes all crypto module loading with "crypto-" so we never run
>>> the risk of exposing module auto-loading to userspace via a crypto API,
>>> as demonstrated by Mathias Krause:
>>>
>>> https://lkml.org/lkml/2013/3/4/70
>>>
>>> Signed-off-by: Kees Cook <keescook@...omium.org>
>>
>> Sorry but this doesn't build for me:
>>
>>   CC [M]  drivers/crypto/qat/qat_common/adf_ctl_drv.o
>> drivers/crypto/qat/qat_common/adf_ctl_drv.c:490:21: error: expected declaration specifiers or ‘...’ before string constant
>> make[3]: *** [drivers/crypto/qat/qat_common/adf_ctl_drv.o] Error 1
>> make[2]: *** [drivers/crypto/qat/qat_common] Error 2
>> make[1]: *** [drivers/crypto/qat] Error 2
>> make[1]: *** Waiting for unfinished jobs....
>
> Looks like drivers/crypto/qat/qat_common/adf_ctl_drv.c is missing
> '#include <linux/crypto.h>'.

Ah, looks like I missed a few in my config. I'll attempt allmodconfig
and send a v2.

Thanks!

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/