linux-kernel - Re: [PATCH V6 00/18] x86: Full support of PAT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54697CAA.5040601@suse.com>
Date:	Mon, 17 Nov 2014 05:42:18 +0100
From:	Jürgen Groß <jgross@...e.com>
To:	Ingo Molnar <mingo@...nel.org>
CC:	hpa@...or.com, x86@...nel.org, tglx@...utronix.de,
	mingo@...hat.com, stefan.bader@...onical.com,
	linux-kernel@...r.kernel.org, xen-devel@...ts.xensource.com,
	konrad.wilk@...cle.com, ville.syrjala@...ux.intel.com,
	david.vrabel@...rix.com, jbeulich@...e.com, toshi.kani@...com,
	plagnioj@...osoft.com, tomi.valkeinen@...com, bhelgaas@...gle.com
Subject: Re: [PATCH V6 00/18] x86: Full support of PAT

On 11/16/2014 02:08 PM, Ingo Molnar wrote:
>
> * Juergen Gross <jgross@...e.com> wrote:
>
>>   arch/x86/include/asm/cacheflush.h         |  38 ++++---
>
> FYI, this series breaks the UML build:
>
> In file included from /home/mingo/tip/include/linux/highmem.h:11:0,
>                   from /home/mingo/tip/include/linux/pagemap.h:10,
>                   from /home/mingo/tip/include/linux/mempolicy.h:14,
>                   from /home/mingo/tip/include/linux/shmem_fs.h:6,
>                   from /home/mingo/tip/init/do_mounts.c:30:
> /home/mingo/tip/arch/x86/include/asm/cacheflush.h:67:36: error: return type is an incomplete type
>   static inline enum page_cache_mode get_page_memtype(struct page *pg)
>                                      ^
> /home/mingo/tip/arch/x86/include/asm/cacheflush.h: In function ‘get_page_memtype’:
> /home/mingo/tip/arch/x86/include/asm/cacheflush.h:69:2: warning: ‘return’ with a value, in function returning void [enabled by default]
>    return -1;
>    ^
> /home/mingo/tip/arch/x86/include/asm/cacheflush.h: At top level:
> /home/mingo/tip/arch/x86/include/asm/cacheflush.h:72:30: error: parameter 2 (‘memtype’) has incomplete type
>           enum page_cache_mode memtype)
>                                ^
> /home/mingo/tip/arch/x86/include/asm/cacheflush.h:71:20: error: function declaration isn’t a prototype [-Werror=strict-prototypes]

Thomas already committed a fixup. Thank you, Thomas.


Juergen

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/