lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 18 Nov 2014 22:20:34 +0100 From: Willy Tarreau <w@....eu> To: Mariusz Gorski <marius.gorski@...il.com> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 6/9] staging: panel: Make two more module params read-only On Tue, Nov 18, 2014 at 09:56:11PM +0100, Mariusz Gorski wrote: > Make keypad_type and lcd_type module params read-only. > This step also starts making it more clear what is > the precedence of device params coming from different > sources (device profile, runtime module param values etc). > > Signed-off-by: Mariusz Gorski <marius.gorski@...il.com> > --- > drivers/staging/panel/panel.c | 71 ++++++++++++++++++++++--------------------- > 1 file changed, 37 insertions(+), 34 deletions(-) > > diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c > index 7f2f5f8..5b4f0a4 100644 > --- a/drivers/staging/panel/panel.c > +++ b/drivers/staging/panel/panel.c > @@ -229,6 +229,9 @@ static struct { > bool enabled; > } lcd; > > +/* Needed only for init */ > +static int selected_lcd_type = NOT_SET; > + > /* contains the LCD config state */ > static unsigned long int lcd_flags; > /* contains the LCD X offset */ > @@ -1417,7 +1420,7 @@ static void panel_lcd_print(const char *s) > /* initialize the LCD driver */ > static void lcd_init(void) > { > - switch (lcd_type) { > + switch (selected_lcd_type) { (...) stupid question : why not move that to the lcd struct you just created instead of creating a new variable ? It would make sense to me to have lcd.type here just like you did with enabled. Same for keypad. Willy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists