linux-kernel - Re: [PATCH 1/1] clk: delete a local variable's repeated assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141118223538.25314.21064@quantum>
Date:	Tue, 18 Nov 2014 14:35:38 -0800
From:	Mike Turquette <mturquette@...aro.org>
To:	Zhen Lei <thunder.leizhen@...wei.com>,
	"linux-kernel" <linux-kernel@...r.kernel.org>
Cc:	"Zefan Li" <lizefan@...wei.com>, "Xinwei Hu" <huxinwei@...wei.com>,
	"Tianhong Ding" <dingtianhong@...wei.com>,
	"Kefeng Wang" <wangkefeng.wang@...wei.com>,
	"Zhen Lei" <thunder.leizhen@...wei.com>
Subject: Re: [PATCH 1/1] clk: delete a local variable's repeated assignment

Quoting Zhen Lei (2014-11-13 18:10:40)
> It's the same to the next statement, "ret = clk->parent". I think compiler will
> optimize it, it's just not looking well.
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>

Applied.

Thanks,
Mike

> ---
>  drivers/clk/clk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index 4896ae9..5307225 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -1614,7 +1614,7 @@ static struct clk *__clk_init_parent(struct clk *clk)
> 
>         if (clk->num_parents == 1) {
>                 if (IS_ERR_OR_NULL(clk->parent))
> -                       ret = clk->parent = __clk_lookup(clk->parent_names[0]);
> +                       clk->parent = __clk_lookup(clk->parent_names[0]);
>                 ret = clk->parent;
>                 goto out;
>         }
> --
> 1.8.0
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/