linux-kernel - Re: [PATCH 1/1 linux-next] ACPI: remove unnecessary sizeof(u8)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3970319.cPmRxBPPro@vostro.rjw.lan>
Date:	Wed, 19 Nov 2014 00:28:32 +0100
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel@...r.kernel.org, Len Brown <lenb@...nel.org>,
	linux-acpi@...r.kernel.org
Subject: Re: [PATCH 1/1 linux-next] ACPI: remove unnecessary sizeof(u8)

On Sunday, November 16, 2014 10:57:00 AM Fabian Frederick wrote:
> sizeof(u8) is always 1.
> 
> Signed-off-by: Fabian Frederick <fabf@...net.be>

Queued up for 3.19-rc1, thanks!

> ---
>  drivers/acpi/utils.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c
> index 371ac12..dd8ff63 100644
> --- a/drivers/acpi/utils.c
> +++ b/drivers/acpi/utils.c
> @@ -136,8 +136,7 @@ acpi_extract_package(union acpi_object *package,
>  				break;
>  			case 'B':
>  				size_required +=
> -				    sizeof(u8 *) +
> -				    (element->buffer.length * sizeof(u8));
> +				    sizeof(u8 *) + element->buffer.length;
>  				tail_offset += sizeof(u8 *);
>  				break;
>  			default:
> @@ -255,7 +254,7 @@ acpi_extract_package(union acpi_object *package,
>  				memcpy(tail, element->buffer.pointer,
>  				       element->buffer.length);
>  				head += sizeof(u8 *);
> -				tail += element->buffer.length * sizeof(u8);
> +				tail += element->buffer.length;
>  				break;
>  			default:
>  				/* Should never get here */
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/