linux-kernel - RE: [PATCH] PCI: rcar: fix error handling of irq_of_parse_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 18 Nov 2014 10:43:36 +0000
From:	Phil Edworthy <phil.edworthy@...esas.com>
To:	Dmitry Torokhov <dtor@...omium.org>,
	Simon Horman <horms@...ge.net.au>
CC:	Bjorn Helgaas <bhelgaas@...gle.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-sh@...r.kernel.org" <linux-sh@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] PCI: rcar: fix error handling of irq_of_parse_and_map

Hi Dmitry,

On 14 November 2014 22:22, Dmitry wrote:
> 
> Return value of irq_of_parse_and_map() is unsigned int, with 0
> indicating failure, so testing for negative result never works.
> 
> Signed-off-by: Dmitry Torokhov <dtor@...omium.org>

Acked-by: Phil Edworthy <phil.edworthy@...esas.com>

Thanks
Phil

> ---
> 
> Not tested, found by casual code inspection.
> 
>  drivers/pci/host/pcie-rcar.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c
> index 9b356c3..6ca976f 100644
> --- a/drivers/pci/host/pcie-rcar.c
> +++ b/drivers/pci/host/pcie-rcar.c
> @@ -764,7 +764,7 @@ static int rcar_pcie_get_resources(struct platform_device
> *pdev,
>  		goto err_map_reg;
> 
>  	i = irq_of_parse_and_map(pdev->dev.of_node, 0);
> -	if (i < 0) {
> +	if (!i) {
>  		dev_err(pcie->dev, "cannot get platform resources for msi
> interrupt\n");
>  		err = -ENOENT;
>  		goto err_map_reg;
> @@ -772,7 +772,7 @@ static int rcar_pcie_get_resources(struct platform_device
> *pdev,
>  	pcie->msi.irq1 = i;
> 
>  	i = irq_of_parse_and_map(pdev->dev.of_node, 1);
> -	if (i < 0) {
> +	if (!i) {
>  		dev_err(pcie->dev, "cannot get platform resources for msi
> interrupt\n");
>  		err = -ENOENT;
>  		goto err_map_reg;
> --
> 2.1.0.rc2.206.gedb03e5
> 
> 
> --
> Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/