linux-kernel - Re: [PATCHv2 1/1] thermal: of: improve of-thermal sensor registration API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141118000133.GA10027@developer>
Date:	Mon, 17 Nov 2014 20:01:36 -0400
From:	Eduardo Valentin <edubezval@...il.com>
To:	Mikko Perttunen <mikko.perttunen@...si.fi>
Cc:	Linux PM <linux-pm@...r.kernel.org>,
	Caesar Wang <caesar.wang@...k-chips.com>,
	Wei Ni <wni@...dia.com>,
	Lukasz Majewski <l.majewski@...sung.com>,
	Alexandre Courbot <gnurou@...il.com>,
	devicetree@...r.kernel.org, Grant Likely <grant.likely@...aro.org>,
	Guenter Roeck <linux@...ck-us.net>,
	Jean Delvare <jdelvare@...e.de>, linux-kernel@...r.kernel.org,
	linux-tegra@...r.kernel.org, lm-sensors@...sensors.org,
	Rob Herring <robh+dt@...nel.org>,
	Stephen Warren <swarren@...dotorg.org>,
	Thierry Reding <thierry.reding@...il.com>,
	Zhang Rui <rui.zhang@...el.com>
Subject: Re: [PATCHv2 1/1] thermal: of: improve of-thermal sensor
 registration API

Mikko,

On Tue, Nov 18, 2014 at 02:11:21AM +0200, Mikko Perttunen wrote:

<big cut>

> > diff --git a/drivers/thermal/tegra_soctherm.c b/drivers/thermal/tegra_soctherm.c
> > index 70f7e9e..893c39c 100644
> > --- a/drivers/thermal/tegra_soctherm.c
> > +++ b/drivers/thermal/tegra_soctherm.c
> > @@ -317,6 +317,10 @@ static int tegra_thermctl_get_temp(void *data, long *out_temp)
> >   	return 0;
> >   }
> >
> > +static const struct thermal_zone_of_device_ops tegra_of_thermal_ops = {
> > +	.get_trend = tegra_thermctl_get_temp,
> > +};
> 
> This should probably read ".get_temp = tegra_thermctl_get_temp" instead 
> of .get_trend :)

Indeed. Sending in v3.

> 
> > ...
> 
> Cheers,
> Mikko
> 

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)