linux-kernel - Re: [PATCH 06/12] media: marvell-ccic: use vb2_ops_wait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+V-a8uC0en+hnsJEA_kUnJRUy4ha4Tb8OY1_JLRUSwHx-XbJQ@mail.gmail.com>
Date:	Tue, 18 Nov 2014 13:23:04 +0000
From:	Prabhakar Lad <prabhakar.csengg@...il.com>
To:	Jonathan Corbet <corbet@....net>
Cc:	Hans Verkuil <hans.verkuil@...co.com>,
	Mauro Carvalho Chehab <m.chehab@...sung.com>,
	LMML <linux-media@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 06/12] media: marvell-ccic: use vb2_ops_wait_prepare/finish
 helper

Hi Jonathan,

On Tue, Nov 18, 2014 at 1:03 PM, Jonathan Corbet <corbet@....net> wrote:
> On Tue, 18 Nov 2014 11:23:35 +0000
> "Lad, Prabhakar" <prabhakar.csengg@...il.com> wrote:
>
>>  drivers/media/platform/marvell-ccic/mcam-core.c | 29 +++++--------------------
>>  1 file changed, 5 insertions(+), 24 deletions(-)
>
> So I'm not convinced that this patch improves things; it moves a tiny bit
> of code into another file where anybody reading the driver will have to
> go look to see what's going on.  But I guess it doesn't really make
> things worse either; I won't try to stand in its way.  It would be nice
> to see a real changelog on the patch, though.
>
Sorry there is no movement of code to other file.  And I dont see any
reason why anybody reading will go haywire its a standard v4l2 thing.
The subject explains it all, If you still want me to elaborate I can
post a v2.

Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/